From 1a763c440f61d3efe77cfdb670371b205451c878 Mon Sep 17 00:00:00 2001 From: Alexander Larsson Date: Fri, 13 Mar 2020 10:49:44 +0100 Subject: [PATCH] broadway: Correctly track surface visibility in client We forgot to unset visible when hiding surfaces --- gdk/broadway/broadway.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/gdk/broadway/broadway.js b/gdk/broadway/broadway.js index 5b8311427c..da1e06fb92 100644 --- a/gdk/broadway/broadway.js +++ b/gdk/broadway/broadway.js @@ -1061,6 +1061,7 @@ function handleCommands(cmd, display_commands, new_textures, modified_trees) doUngrab(); surface = surfaces[id]; if (surface.visible) { + surface.visible = false; display_commands.push([DISPLAY_OP_HIDE_SURFACE, surface.div]); } break; @@ -1109,13 +1110,13 @@ function handleCommands(cmd, display_commands, new_textures, modified_trees) surface = surfaces[id]; if (has_pos) { surface.positioned = true; - surface.x = cmd.get_16s();; - surface.y = cmd.get_16s();; + surface.x = cmd.get_16s(); + surface.y = cmd.get_16s(); display_commands.push([DISPLAY_OP_MOVE_NODE, surface.div, surface.x, surface.y]); } if (has_size) { surface.width = cmd.get_16(); - surface.height = cmd.get_16();; + surface.height = cmd.get_16(); display_commands.push([DISPLAY_OP_RESIZE_NODE, surface.div, surface.width, surface.height]); } -- 2.30.2